Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Blanket Tolerations / Affinity for all node executions #439

Closed
1 of 13 tasks
kumare3 opened this issue Jul 31, 2020 · 1 comment
Closed
1 of 13 tasks

[Feature]Blanket Tolerations / Affinity for all node executions #439

kumare3 opened this issue Jul 31, 2020 · 1 comment
Assignees
@EngHabu @kumare3
Labels
enhancement New feature or request
Milestone
0.7.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jul 31, 2020

Motivation: Why do you think this is important?
In cases when Flyte is deployed to a shared environment (shared with online services etc), users may want to segregate all pods scheduled by Flyte to a separate node pool. This can be achieved using affinity or tolerations. This change will make it easy to apply such affinity / tolerations to all K8s executions - Containers (python task etc), sidecars, pytorch etc (even spark after spark 3.0)

Goal: What should the final outcome look like, ideally?
All pods scheduled land on some specific node pool configured in the backend.

Describe alternatives you've considered
use sidecar for every execution, this prevents using other task types easily

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
NA

Additional context
This will help solve Issue #435 Part - 1

Is this a blocker for you to adopt Flyte
NA
@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jul 31, 2020
@kumare3
Copy link
Contributor Author

kumare3 commented Jul 31, 2020

cc @jeevb

@kumare3 kumare3 added this to the 0.7.0 milestone Jul 31, 2020
@kumare3 kumare3 self-assigned this Jul 31, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 31, 2020
This was referenced Jul 31, 2020
Closed
Merged
@EngHabu EngHabu modified the milestones: 0.7.0, 0.8.0 Aug 5, 2020
@EngHabu EngHabu self-assigned this Aug 5, 2020
@EngHabu EngHabu closed this as completed Aug 5, 2020
@EngHabu EngHabu modified the milestones: 0.8.0, 0.7.0 Sep 2, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
Graceful failure on ExecutionNotFound error (flyteorg#439)
ba197a0 
* updated ExecutionNotFound to check failed attempts rather than workflow state

Signed-off-by: Daniel Rammer <[email protected]>

* added unit test to allow continue until maxRetries

Signed-off-by: Daniel Rammer <[email protected]>

* added dropping ExecutionNotFound error when aborting workflow

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pmahindrakar-oss
Moving backward compat authrole code in one place and also removed re…
7327677 
…dundant fields (flyteorg#439)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@pingsutw
Added snowflake example (flyteorg#439)
292e7b6 
* Added snowflake example

Signed-off-by: Kevin Su <[email protected]>

* Updated rst files

Signed-off-by: Kevin Su <[email protected]>

* Updated rst files

Signed-off-by: Kevin Su <[email protected]>

* Updated rst files

Signed-off-by: Kevin Su <[email protected]>

* Rebased PR

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Graceful failure on ExecutionNotFound error (flyteorg#439)
a0db3e4 
* updated ExecutionNotFound to check failed attempts rather than workflow state

Signed-off-by: Daniel Rammer <[email protected]>

* added unit test to allow continue until maxRetries

Signed-off-by: Daniel Rammer <[email protected]>

* added dropping ExecutionNotFound error when aborting workflow

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pmahindrakar-oss
Moving backward compat authrole code in one place and also removed re…
d3550ba 
…dundant fields (flyteorg#439)
eapolinario pushed a commit that referenced this issue Sep 26, 2023
@ByronHsu
[flyteidl] Support attribute access on promises (#439)
965f861 
* init

Signed-off-by: byhsu <[email protected]>

* fix typo

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
pvditt pushed a commit that referenced this issue Dec 29, 2023
@ByronHsu
[flyteidl] Support attribute access on promises (#439)
fc20673 
* init

Signed-off-by: byhsu <[email protected]>

* fix typo

Signed-off-by: byhsu <[email protected]>

---------

Signed-off-by: byhsu <[email protected]>
Co-authored-by: byhsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

@kumare3 kumare3

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@EngHabu @kumare3