Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Make flytekit plugins use lazy module loading #4401

Closed
2 tasks done
cosmicBboy opened this issue Nov 10, 2023 · 1 comment · Fixed by flyteorg/flytekit#2049
Closed
2 tasks done

[Housekeeping] Make flytekit plugins use lazy module loading #4401

cosmicBboy opened this issue Nov 10, 2023 · 1 comment · Fixed by flyteorg/flytekit#2049
Assignees
@cosmicBboy
Labels
backlogged For internal use. Reserved for contributor team workflow. housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@cosmicBboy
Copy link
Contributor

Describe the issue

The problem is that some python packages are problematic in terms of reliably installing them across different os's and architectures. This makes it a challenge to build docs that require these packages to be installed.

By using lazy module loading, we can build docs without having the dependencies installed.

What if we do not do this?

Building docs will continue being painful.

Related component(s)

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added housekeeping Issues that help maintain flyte and keep it tech-debt free backlogged For internal use. Reserved for contributor team workflow. labels Nov 10, 2023
@Future-Outlier
Copy link
Member

This PR can help you finish the issue faster.
flyteorg/flytekit#1590

@cosmicBboy cosmicBboy changed the title [Housekeeping] Make tensorflow and vaex flytekit plugins use lazy module loading [Housekeeping] Make flytekit plugins use lazy module loading Dec 8, 2023
@cosmicBboy cosmicBboy self-assigned this Dec 8, 2023
This was referenced Dec 12, 2023
Closed
Merged
@Future-Outlier Future-Outlier mentioned this issue Jan 11, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cosmicBboy cosmicBboy

Labels
backlogged For internal use. Reserved for contributor team workflow. housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Milestone
No milestone
2 participants
@cosmicBboy @Future-Outlier