all flytekit plugins use lazy module loading #2045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
force-pushed
the
plugins-use-lazy-module
branch
from
dd5c5e9 to
238a7b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
+ Coverage 83.18% 84.54% +1.35%
==========================================
Files 173 231 +58
Lines 16840 19191 +2351
Branches 3471 3468 -3
==========================================
+ Hits 14009 16225 +2216
- Misses 2236 2366 +130
- Partials 595 600 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
|
The offending file in the failing lint test isn't changed in this PR, not sure what's going on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Fixes flyteorg/flyte#4401
Why are the changes needed?
This change is primarily to simplify the dependencies needed for things like generating API reference documentation for flytekit. Before one needed all dependencies of all plugins to render API docs.
What changes were proposed in this pull request?
Use
flytekit.lazy_moduleto lazily load modules in the plugin packages.How was this patch tested?
Run tests locally with pytest