-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Remove references to unused plugins in flytekit api docs #4539
Comments
🤖 Hello @cosmicBboy! I'm Dosu, a bot here to assist you with bugs, answer questions, and guide you on your journey to becoming a contributor. While we wait for a human maintainer to respond, feel free to ask me any questions you may have. I'm here to help! Based on the information provided, the references to the Sagemaker plugin in the flytekit API reference docs are located in the file The Sagemaker plugin is specified in the configmap:
enabled_plugins:
tasks:
task-plugins:
enabled-plugins:
- container
- sidecar
- k8s-array
- sagemaker_training
- sagemaker_hyperparameter_tuning
default-for-task-types:
container: container
sidecar: sidecar
container_array: k8s-array The Sagemaker plugin example is registered using the flytectl register files https://github.com/flyteorg/flytesnacks/releases/download/v0.3.0/snacks-cookbook-integrations-aws-sagemaker_training.tar.gz --archive -p flytesnacks -d development And an execution is launched using the flytectl --config ~/.flyte/flytectl.yaml create execution \
-p <project> -d <domain> --execFile ~/exec_spec.yaml To deprecate the Sagemaker plugin, you would need to remove these references from the As for the exact functionality of the Sagemaker plugin in the Flytekit API, I wasn't able to find an answer within the repository. It might be helpful to look at the Sagemaker plugin's source code or documentation for more information. Please let me know if you need further assistance. SourcesThis response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot. |
Fixed by flyteorg/flytekit#2025 |
Describe the issue
The purpose of this issue is to remove the
awssagemaker
andfsspec
plugin from the api docs.[Core feature] Sagemaker Agent #4079. The purpose of this task is to remove references
to this plugin in the flytekit api reference docs.
What if we do not do this?
This will cause warnings in the docs build process, since
flyteidl.plugins.sagemaker
no longer exists.Related component(s)
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: