Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore warnings related to awssagemaker import #4540

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

cosmicBboy
Copy link
Contributor

This PR is a temporary fix to the monodocs build process: it ignores a warning related to importing.

Will need to update flytekit docs: #4539

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9423d1f) 60.09% compared to head (f2bbe56) 60.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4540   +/-   ##
=======================================
  Coverage   60.09%   60.09%           
=======================================
  Files         440      440           
  Lines       36110    36110           
=======================================
  Hits        21699    21699           
  Misses      12684    12684           
  Partials     1727     1727           
Flag Coverage Δ
unittests 60.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2023
@eapolinario eapolinario enabled auto-merge (squash) December 6, 2023 17:59
@eapolinario eapolinario merged commit 2105f09 into master Dec 6, 2023
41 checks passed
@eapolinario eapolinario deleted the docs-remove-awssagemaker branch December 6, 2023 18:24
pvditt pushed a commit that referenced this pull request Dec 13, 2023
Signed-off-by: Niels Bantilan <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants