Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Monodocs: add configuration to show tag/release in the monodocs build output #4560

Closed
2 tasks done
cosmicBboy opened this issue Dec 8, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels
backlogged For internal use. Reserved for contributor team workflow. documentation Improvements or additions to documentation

Comments

@cosmicBboy
Copy link
Contributor

cosmicBboy commented Dec 8, 2023

Description

The purpose of this task is to make the monodocs build process more transparent by showing the git tag and commit associated with the flytekit, flytesnacks, and flytectl repos when the monodocs are built.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Dec 8, 2023
@cosmicBboy cosmicBboy self-assigned this Dec 8, 2023
@cosmicBboy cosmicBboy added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 8, 2023
Copy link

dosubot bot commented Dec 8, 2023

🤖

Hello @cosmicBboy! 👋

I'm Dosu, a friendly bot here to assist you while we wait for a human maintainer. I can help you solve bugs, answer questions, and guide you to become a contributor. Looking forward to working with you! 😊

Yes, it is possible to add a configuration to the monodocs build process to specify a specific tag when cloning the flytekit, flytesnacks, and flytectl repositories for their documentation content. This can be achieved by modifying the import_projects list in the docs/conf.py file.

Each dictionary in the import_projects list represents a project to be cloned. The source key specifies the repository to be cloned. If you want to clone a specific tag, you can append the tag to the repository URL. For example, to clone the v0.1.0 tag of the flytekit repository, you can change the source from "https://github.com/flyteorg/flytekit" to "https://github.com/flyteorg/flytekit.git#v0.1.0".

Here is how you can modify the import_projects list to clone specific tags:

import_projects = [
    {
        "source": flytesnacks_local_path or "https://github.com/flyteorg/flytesnacks.git#<tag>",
        "docs_path": "docs",
        "dest": "flytesnacks",
        "cmd": [
            ["cp", "-R", f"{flytesnacks_path}/examples", "./examples"],
            [
                # remove un-needed docs files in flytesnacks
                "rm",
                "-rf",
                "flytesnacks/jupyter_execute",
                "flytesnacks/auto_examples",
                "flytesnacks/_build",
                "flytesnacks/_tags",
            ]
        ],
        "local": flytesnacks_local_path is not None,
    },
    {
        "source": flytekit_local_path or "https://github.com/flyteorg/flytekit.git#<tag>",
        "docs_path": "docs/source",
        "dest": "api/flytekit",
        "cmd": [
            ["mkdir", "-p", import_projects_config["flytekit_api_dir"]],
            ["cp", "-R", f"{flytekit_path}/flytekit", import_projects_config["flytekit_api_dir"]],
            ["cp", "-R", f"{flytekit_path}/plugins", import_projects_config["flytekit_api_dir"]],
            ["cp", "-R", f"{flytekit_path}/tests", "./tests"],
        ],
        "local": flytekit_local_path is not None,
    },
    {
        "source": flytectl_local_path or "https://github.com/flyteorg/flytectl.git#<tag>",
        "docs_path": "docs/source",
        "dest": "flytectl",
        "local": flytectl_local_path is not None,
    },
    {
        "source": "../flyteidl",
        "docs_path": "protos",
        "dest": "protos",  # to stay compatible with flyteidl docs path naming
        "cmd": ["cp", "../flyteidl/README.md", "protos/README.md"],
        "local": True,
    }
]

Replace <tag> with the tag you want to clone. You can find more details in the docs/conf.py file.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@cosmicBboy cosmicBboy changed the title [Docs] Monodocs: add configuration to specify tag/release when cloning flytekit/flytesnacks/flytectl [Docs] Monodocs: add configuration to show tag/release in the monodocs build output Dec 11, 2023
@cosmicBboy
Copy link
Contributor Author

fixed by: d5f0002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant