-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add repo tag and commit associated with the build #4571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Dec 11, 2023
Signed-off-by: Niels Bantilan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4571 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 621 621
Lines 52498 52498
=======================================
Hits 30974 30974
Misses 19057 19057
Partials 2467 2467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thomasjpfan
reviewed
Dec 12, 2023
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
thomasjpfan
reviewed
Dec 13, 2023
pingsutw
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
To make the docs more transparent. This will make it clear which version of flytekit, flytesnacks, and flytectl were used to build a particular instance of the docs. The monodocs build process will use the latest tag available in the corresponding repo.
What changes were proposed in this pull request?
_templates/page.html
file that adapts the furo page.html filename
attribute to theimport_projects.Project
dataclasshtml_context
How was this patch tested?