Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add repo tag and commit associated with the build #4571

Merged
merged 10 commits into from
Dec 13, 2023

Conversation

cosmicBboy
Copy link
Contributor

@cosmicBboy cosmicBboy commented Dec 11, 2023

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

To make the docs more transparent. This will make it clear which version of flytekit, flytesnacks, and flytectl were used to build a particular instance of the docs. The monodocs build process will use the latest tag available in the corresponding repo.

What changes were proposed in this pull request?

  • Adds a custom _templates/page.html file that adapts the furo page.html file
  • Adds a name attribute to the import_projects.Project dataclass
  • Injects the necessary metadata into html_context
Screenshot 2023-12-11 at 6 51 47 PM

How was this patch tested?

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 11, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c84e46) 59.00% compared to head (0e843dc) 59.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4571   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files         621      621           
  Lines       52498    52498           
=======================================
  Hits        30974    30974           
  Misses      19057    19057           
  Partials     2467     2467           
Flag Coverage Δ
unittests 59.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/.readthedocs.yaml Outdated Show resolved Hide resolved
docs/_templates/page.html Show resolved Hide resolved
@cosmicBboy cosmicBboy enabled auto-merge (squash) December 13, 2023 19:34
@cosmicBboy cosmicBboy merged commit d5f0002 into master Dec 13, 2023
45 checks passed
@cosmicBboy cosmicBboy deleted the monodocs-checkout-tag branch December 13, 2023 19:59
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants