Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] For non in-cluster setup, flyteadmin fails to choose a cluster if no matching resource configured #481

Closed
4 of 20 tasks
honnix opened this issue Aug 25, 2020 · 0 comments
Closed
4 of 20 tasks

[BUG] For non in-cluster setup, flyteadmin fails to choose a cluster if no matching resource configured #481

honnix opened this issue Aug 25, 2020 · 0 comments
Assignees
@honnix
Labels
bug Something isn't working

Comments

@honnix
Copy link
Member

honnix commented Aug 25, 2020

Describe the bug
For a non in-cluster setup where flyteadmin is deployed outside of the k8s cluster where flytepropeller runs, if there is no matching (resource-type/domain being mandatory while project/workflow/launch-plan optional) resource defined in resources table, flyteadmin stops choosing a cluster prematurely.

Expected behavior
When no matching resource found, flyteadmin should move on and pick up a random cluster.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Deploy flytepropeller in a k8s cluster
  2. Make sure resources table is empty
  3. Run flyteadmin outside of the said cluster
  4. Execute a launch plan from flyteconsole
  5. It can be observed that flyteadmin returns 500
  6. By examining flyteadmin logs, it can be observed that flyteadmin complains Resource[project,domain,workflow,launch_plan,resource_type] not found

Screenshots
NA

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other
@honnix honnix added the bug Something isn't working label Aug 25, 2020
@honnix honnix self-assigned this Aug 25, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
Use correct node ID when recovery subworkflow nodes (flyteorg#481)
a0d01ce 
* using fully qualified node id on recovery

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@iaroslav-ciupin
Cluster pool based execution assignment (flyteorg#481)
6cc951f 
* cluster pool execution assignment

Signed-off-by: Iaroslav Ciupin <[email protected]>

* update flyteidl

Signed-off-by: Iaroslav Ciupin <[email protected]>

* update flyteidl

Signed-off-by: Iaroslav Ciupin <[email protected]>

Signed-off-by: Iaroslav Ciupin <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@cosmicBboy
update extending flyte flowchart (flyteorg#481)
10c923f 
* update extending flyte flowchart

Signed-off-by: Niels Bantilan <[email protected]>

* updates

Signed-off-by: Niels Bantilan <[email protected]>

* style update

Signed-off-by: Niels Bantilan <[email protected]>
pingsutw pushed a commit to pingsutw/flyte-monorepo that referenced this issue Apr 4, 2023
@honnix
Allow random cluster selection when no override (#117)
b37b76a 
In case there is no override in resource table, we should allow the code
to go through and apply non-label based weighted random selection.

Close flyteorg/flyte#481
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Use correct node ID when recovery subworkflow nodes (flyteorg#481)
31c6efa 
* using fully qualified node id on recovery

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@iaroslav-ciupin
Cluster pool based execution assignment (flyteorg#481)
6911752 
* cluster pool execution assignment

Signed-off-by: Iaroslav Ciupin <[email protected]>

* update flyteidl

Signed-off-by: Iaroslav Ciupin <[email protected]>

* update flyteidl

Signed-off-by: Iaroslav Ciupin <[email protected]>

Signed-off-by: Iaroslav Ciupin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honnix honnix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@honnix