Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Use remote LP with default inputs and no fixe inputs is not working #5270

Closed
2 tasks done
andresgomezfrr opened this issue Apr 23, 2024 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@andresgomezfrr
Copy link
Contributor

Describe the bug

Use remote LP with default input and no fixed inputs fails during registration time with:
https://github.com/flyteorg/flytekit/blob/master/flytekit/core/promise.py#L972

    raise _user_exceptions.FlyteAssertion("Missing input `{}` type `{}`".format(k, var.type))

Expected behavior

The LP should be registered properly if the inputs are provided using the default inputs even if there are no fixed inputs configured.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@andresgomezfrr andresgomezfrr added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Apr 23, 2024
Copy link

runllm bot commented Apr 23, 2024

To address the bug where using a remote Launch Plan (LP) with default inputs and no fixed inputs fails during registration, it's important to ensure that the default inputs are correctly specified and match the expected types defined in the workflow. The error you encountered suggests a mismatch or absence of required inputs during the LP registration process.

For a scheduled launch plan, either fixed inputs or default inputs with default values must be provided. If a default input is marked as required, the corresponding fixed input should be specified. If it has a default value, a fixed input is not necessary. This behavior should be validated during the LP registration to prevent such errors (source).

Would you like more detailed guidance on how to correctly configure and validate the inputs for your Launch Plan to avoid this issue?


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@andresgomezfrr andresgomezfrr changed the title [BUG] [BUG] Use remote LP with default inputs and no fixe inputs is not working Apr 23, 2024
@davidmirror-ops
Copy link
Contributor

Fixed on flyteorg/flytekit#2372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

2 participants