Fix use default inputs with remote LaunchPlan #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgomezfrr
force-pushed
the
fix-default-inputs-in-remote-lp
branch
from
a096398 to
6db9f0d
Compare
Signed-off-by: Andres Gomez Ferrer <[email protected]>
andresgomezfrr
force-pushed
the
fix-default-inputs-in-remote-lp
branch
from
6db9f0d to
b85a4fc
Compare
andresgomezfrr
commented
Apr 23, 2024
andresgomezfrr
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
I think you need to merge this one, I can't do it @pingsutw |
Closed
2 tasks
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 9, 2024
Signed-off-by: Andres Gomez Ferrer <[email protected]>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 10, 2024
Signed-off-by: Andres Gomez Ferrer <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Andres Gomez Ferrer <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5270
Why are the changes needed?
These changes are needed to use remote LP without fixed inputs when input + default inputs are provided.
What changes were proposed in this pull request?
In line comment
How was this patch tested?
Unit test and manual test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link