Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Better error msg when re-registering an identical node in a workflow #535

Open
4 of 20 tasks
katrogan opened this issue Oct 5, 2020 · 7 comments
Open
4 of 20 tasks

[BUG] Better error msg when re-registering an identical node in a workflow #535

katrogan opened this issue Oct 5, 2020 · 7 comments
Labels
bug Something isn't working stale

Comments

@katrogan
Copy link
Contributor

katrogan commented Oct 5, 2020

Describe the bug
Currently if a user programmatically re-adds an existing node to a workflow, the reported error message isn't particularly clear:

flytekit.common.exceptions.user.FlyteAssertion: Some nodes contained in the workflow were not found in the workflow description. Please ensure all nodes are either assigned to attributes within the class or an element in a list, dict, or tuple which is stored as an attribute in the class.

Expected behavior
It should be apparent what the underlying issue is

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Add any other context about the problem here.
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 5, 2020
@kumare3 kumare3 added this to the 0.10.0 milestone Oct 15, 2020
@EngHabu EngHabu removed this from the 0.10.0 milestone Jan 11, 2021
@slai slai mentioned this issue Jan 22, 2021
Closed
13 tasks
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Feb 1, 2022
@kumare3
Copy link
Contributor

kumare3 commented Feb 1, 2022

Is this bug still active?

@katrogan
Copy link
Contributor Author

katrogan commented Feb 1, 2022

@kumare3 wow this old, not sure! can we try repro-ing?

@kumare3
Copy link
Contributor

kumare3 commented Feb 2, 2022

@kumare3 wow this old, not sure! can we try repro-ing?

I do not follow the steps

@katrogan
Copy link
Contributor Author

katrogan commented Feb 3, 2022

@jahagaley do you recall?

eapolinario added a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@eapolinario
Extend pod webhook self-signed certs expiration date to 99 years in t…
328a41c 
…he future (flyteorg#535)

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario added a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@eapolinario
Extend pod webhook self-signed certs expiration date to 99 years in t…
05288d2 
…he future (flyteorg#535)

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EngHabu @eapolinario @katrogan @kumare3