Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] flyteconsole cors proxying part has broken link and is a bit unclear #560

Closed
1 of 20 tasks
honnix opened this issue Oct 20, 2020 · 0 comments · Fixed by flyteorg/flyteconsole#561
Closed
1 of 20 tasks

[BUG] flyteconsole cors proxying part has broken link and is a bit unclear #560

honnix opened this issue Oct 20, 2020 · 0 comments · Fixed by flyteorg/flyteconsole#561
Assignees
@honnix
Labels
bug Something isn't working

Comments

@honnix
Copy link
Member

honnix commented Oct 20, 2020 •
edited
Loading

Describe the bug
This link https://github.com/lyft/flyteconsole#cors-proxy is broken, I guess due to section renaming I see it is custom anchor not working.

Also it is not straight forward to understand how to configure ADMIN_API_URL to use the CORS proxy.

Expected behavior
Broken link is fixed and an example of ADMIN_API_URL is given.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
NA

Screenshots
NA

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
NA
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 20, 2020
@honnix honnix mentioned this issue Oct 20, 2020
Merged
8 tasks
@honnix honnix self-assigned this Oct 20, 2020
@honnix honnix removed the untriaged This issues has not yet been looked at by the Maintainers label Oct 20, 2020
@honnix honnix closed this as completed Oct 20, 2020
@james-union james-union mentioned this issue Aug 12, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honnix honnix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Dict value loses 1 trailing character on UI Launch. flyteorg/flyteconsole
1 participant
@honnix