Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme #108

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Fix readme #108

merged 3 commits into from
Oct 20, 2020

Conversation

honnix
Copy link
Member

@honnix honnix commented Oct 20, 2020

TL;DR

Fix readme.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Fixed the custom anchor to make it more GitHub friendly
  • Added example how to use CORS proxy
  • Described how to use dotenv

Tracking Issue

flyteorg/flyte#560

Follow-up issue

NA

@@ -112,7 +114,7 @@ a single module, you can specify that one specifically
(ex. ``localStorage.debug = 'flyte:adminEntity'`` to only see decoded Flyte
Admin API requests).

.. _cors-proxy:
.. _cors-proxying:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess either GitHub doesn't read this or there is some sort of weird logic. This change basically makes the custom anchor being the same as what is generated by GitHub from section header.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh huh. That is strange.

@@ -112,7 +114,7 @@ a single module, you can specify that one specifically
(ex. ``localStorage.debug = 'flyte:adminEntity'`` to only see decoded Flyte
Admin API requests).

.. _cors-proxy:
.. _cors-proxying:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh huh. That is strange.

@schottra schottra merged commit 619e3ec into flyteorg:master Oct 20, 2020
@honnix honnix deleted the fix-readme branch October 20, 2020 18:37
@service-github-lyft-semantic-release
Copy link
Contributor

🎉 This PR is included in version 0.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants