Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow download of Inputs / Outputs #58

Closed
georgesnelling opened this issue Nov 19, 2019 · 3 comments
Closed

Allow download of Inputs / Outputs #58

georgesnelling opened this issue Nov 19, 2019 · 3 comments
Labels
ui Admin console user interface

Comments

@georgesnelling
Copy link
Contributor

georgesnelling commented Nov 19, 2019 •
edited by schottra
Loading

It's unclear exactly what format things should be in, but for I/O types like CSV/Blob/Schema we should be able to provide a download link for the user.

Options:

  1. Convert it to a signed S3 link. This is probably not the right move because we need to verify the identity of a user before allowing them to download
  2. Convert the s3:// protocol to an actual s3 link. It would be up to the user to ensure they are assuming the correct role to be able to download the file.

Likely it will be option 2.

For things like CSV list, we have to consider how to display a list of these items.
@kumare3
Copy link
Contributor

kumare3 commented Jul 6, 2020

@schottra I think there are a lot of tasks assigned to you. Can you go over them once and let me know where you can use help. Also having a UX link for most of them would be great

@schottra
Copy link
Contributor

schottra commented Jul 6, 2020

@kumare3 This item doesn't have any UX design or mocks other than the thoughts listed in the description. I'm open to ideas for a good experience.

Pretty much anything that others want to pick up is fine with me. The things marked "pri1" would need discussion first, since those are mostly major feature efforts.

@schottra schottra added ui Admin console user interface and removed pri3 labels Jul 6, 2020
@schottra schottra removed their assignment Jul 6, 2020
@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

Bug bankruptcy.

@EngHabu EngHabu closed this as completed Jan 29, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@surindersinghp
Fixing the output dir in workflow event sent to Admin (flyteorg#58)
d3d7d00 
* test

* .

* new rm

* increment attempt after finalize, just before marking it running again

* test

* updating dependencies
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Handle resource override not found in cluster resource controller (fl…
d3e4ec4 
…yteorg#58)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
Abort AWS Batch Job on Finalize (flyteorg#58)
a931a40 
AWS Batch Plugin can determine that a task has failed if it detects it can no longer satisfy the failure ratio requirement. When this happens the array task node will be terminated then retried (if there are retry count available). This should trigger a cancellation to the AWS Job as well. 

It was originally written this way to match the old version of this code that, upon discussion, has been deemed a bad design. 

- [X] Need to ensure the cancellation API is idempotent (or add error check/ignore if it's not)
         Validated by running a Workflow and waiting for it to kick off an AWS Job then aborting it. That ended up calling Abort() then Finalize() and the second call was no-op
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@honnix
support regexp config (flyteorg#58)
8c7e01b
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@wild-endeavor
Generate uuid in go rather than in db (flyteorg#58)
1c729ea 
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia
Flytectl get started updated (flyteorg#58)
e2a8d11 
Signed-off-by: yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@surindersinghp
Fixing the output dir in workflow event sent to Admin (flyteorg#58)
e28ade0 
* test

* .

* new rm

* increment attempt after finalize, just before marking it running again

* test

* updating dependencies
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Handle resource override not found in cluster resource controller (fl…
80e8964 
…yteorg#58)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Abort AWS Batch Job on Finalize (flyteorg#58)
a6d94de 
AWS Batch Plugin can determine that a task has failed if it detects it can no longer satisfy the failure ratio requirement. When this happens the array task node will be terminated then retried (if there are retry count available). This should trigger a cancellation to the AWS Job as well. 

It was originally written this way to match the old version of this code that, upon discussion, has been deemed a bad design. 

- [X] Need to ensure the cancellation API is idempotent (or add error check/ignore if it's not)
         Validated by running a Workflow and waiting for it to kick off an AWS Job then aborting it. That ended up calling Abort() then Finalize() and the second call was no-op
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@honnix
support regexp config (flyteorg#58)
4f003ea
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@wild-endeavor
Generate uuid in go rather than in db (flyteorg#58)
3f61f67 
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Update flytestdlib to 0.4.17 (flyteorg#58)
5a165b7 
Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 7, 2023
@wild-endeavor
Generate uuid in go rather than in db (#58)
29a5e24 
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@pingsutw
Install protoc before generating docs (#58)
a89da70
pmahindrakar-oss pushed a commit that referenced this issue Feb 5, 2024
@andrewwdye
Logger disable HTML escaping (#4828) (#58)
8ff4d66 
Signed-off-by: Andrew Dye <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
Flytectl get started updated (flyteorg#58)
514375f 
Signed-off-by: yuvraj <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @austin362667
Flytectl get started updated (flyteorg#58)
6603b2f 
Signed-off-by: yuvraj <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@yindia @robert-ulbrich-mercedes-benz
Flytectl get started updated (flyteorg#58)
940a3c8 
Signed-off-by: yuvraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui Admin console user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EngHabu @georgesnelling @schottra @kumare3