Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][UI] View Children on Task Execution leads to empty view #672

Closed
1 of 13 tasks
schottra opened this issue Jan 15, 2021 · 1 comment
Closed
1 of 13 tasks

[BUG][UI] View Children on Task Execution leads to empty view #672

schottra opened this issue Jan 15, 2021 · 1 comment
Assignees
@schottra
Labels
bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers

Comments

@schottra
Copy link
Contributor

Describe the bug
Viewing the details for a Task Execution node and clicking on View Children will lead me to an empty view.

Expected behavior
Should show an Execution Details view scoped to the selected Task Execution

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Open Execution Details view for any execution which uses a dynamic task execution.
  2. Click on the NodeExecution in the table for the dynamic task.
  3. In the Executions tab of the Details Panel, select the View Children link.
  4. Observe.

Additional context
I did some digging and this has to do with the way we initialize the query for TaskExecutionDetails. Specifically, useConditionalQuery has logic to set the enabled flag to false on the initialization of the query if we find existing query data and the passed shouldEnableFn returns false. A potential solution would be to leave the query enabled and set the stale time to Infinity if the condition function returns false.
@schottra schottra added bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Jan 15, 2021
@schottra schottra self-assigned this Jan 15, 2021
@schottra schottra mentioned this issue Jan 15, 2021
Merged
3 tasks
@schottra
Copy link
Contributor Author

fixed by flyteorg/flyteconsole#142
available in flyteconsole v0.19.3

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@AlekhyaSasi @yindia
@SmritiSatyanV @pingsutw @samhita-alla @cosmicBboy
Remove flyte-cli references in the documentation (flyteorg#672)
ac979a7 
* Added reuse able workflow (flyteorg#660)

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add directive (flyteorg#663)

Signed-off-by: SmritiSatyanV <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Added links from Flytelab (flyteorg#652)

* Added link from Flytelab

Added weather forecasting application link
Minor grammar fixes
Signed-off-by: SmritiSatyanV <[email protected]>

* Created weather_forecast.rst

Created rst file to add github repo to weather-forecasting, and blog
Signed-off-by: SmritiSatyanV <[email protected]>

* Fixed errors-1

Signed-off-by: SmritiSatyanV <[email protected]>

* Updated weather_forecasting.rst

Signed-off-by: SmritiSatyanV <[email protected]>

* Added flytelab and blog link

Added description, and right links.
Signed-off-by: SmritiSatyanV <[email protected]>

* Changes to tutorials.rst

Placed the weather forecasting tab in a different position
Signed-off-by: SmritiSatyanV <[email protected]>

* updated ml_training.rst

Added description for ml_training file
Signed-off-by: SmritiSatyanV <[email protected]>

* Changes based on review

Signed-off-by: SmritiSatyanV <[email protected]>

* Changed weather forecasting drop down to flytelab

Signed-off-by: SmritiSatyanV <[email protected]>

* Changes based on comments

Signed-off-by: SmritiSatyanV <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add AWS Batch example (flyteorg#636)

* Added aws batch example

Signed-off-by: Kevin Su <[email protected]>

* Updated dependency

Signed-off-by: Kevin Su <[email protected]>

* Update dockerfile

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* rerun tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* rerun tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* address comment

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Moving register files example to use flytectl

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update fast serialization

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samhita Alla <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samhita Alla <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Updated index.rst (flyteorg#670)

rephrased a sentence
Signed-off-by: SmritiSatyanV <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Minor updates (flyteorg#669)

* Minor updates
Grammar, and rendering fix
Updates based on comments
Update contribute.rst
Signed-off-by: SmritiSatyanV <[email protected]>

* Moving panel-and-toc image to static-resources repo and updating the url (flyteorg#671)

Co-authored-by: Alekhya Sai <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update backend_plugins.py (flyteorg#653)

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update fast_registration.py

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update flyte_python_types.py iteration 1

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Remove flyte-cli references

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Remove fast_registration.py in favor of deploying_workflows.py

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Rewording a few sentences

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add new line

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Remove references from lp_schedules.py

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update instructions

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update settings commnent

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Worked on review suggestions

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add alternative option

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: SmritiSatyanV <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Co-authored-by: Samhita Alla <[email protected]>
Co-authored-by: Niels Bantilan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schottra schottra

Labels
bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schottra