-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKE single cluster configuration archetype #12
Conversation
Demo purposes. To make it work, users will need to change some config
name: staging | ||
- id: production | ||
name: production | ||
- id: domain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's nix this.
access-key: minio | ||
auth-type: accesskey | ||
disable-ssl: true | ||
endpoint: http://minio.flyte.svc.cluster.local:9000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're going to stick with using Minio for this? should we move to gcs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we move to gcs?
Moving to GCS will be good..
registration: | ||
maxWorkflowNodes: 100 | ||
scheduler: | ||
eventScheduler: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove this section completely or is there a gcp equivalent we can move to?
- --config | ||
- /etc/flyte/config/flyteadmin_config.yaml | ||
- serve | ||
image: docker.io/lyft/flyteadmin:v0.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this says 0.1.4, but the overlay file has 0.1.1. I'll remove that at some point. no reason to specify if it's not being used.
containers: | ||
- name: flytepropeller | ||
env: | ||
- name: QUBOLE_API_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen if we don't use QUBOLE?
Is this still valid @kumare3 ? |
* Update code of conduct Signed-off-by: Samhita Alla <[email protected]> * boilerpalte Signed-off-by: Samhita Alla <[email protected]>
* Update code of conduct Signed-off-by: Samhita Alla <[email protected]> * boilerpalte Signed-off-by: Samhita Alla <[email protected]>
* Updating GH workflows to not use the same hard-coded package name across all repos * doc update * Updating readme with a note about forks
…lyteorg#12) * More updates * Updated readme * more updates * more updates
…lyteorg#12) * More updates * Updated readme * more updates * more updates
Demo purposes. To make it work, users will need to change some config