Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgot to bump console #137

Merged
merged 1 commit into from
Dec 10, 2019
Merged

forgot to bump console #137

merged 1 commit into from
Dec 10, 2019

Conversation

wild-endeavor
Copy link
Contributor

No description provided.

@wild-endeavor wild-endeavor merged commit b911264 into master Dec 10, 2019
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
# TL;DR
Adds a generic labeled gauge for K8s plugin resources

## Type
 - [ ] Bug Fix
 - [x] Feature
 - [ ] Plugin

## Are all requirements met?

 - [x] Code completed
 - [x] Smoke tested
 - [x] Unit tests added
 - [x] Code documentation added
 - [x] Any pending items have an associated Issue

## Complete description
* We are adding a generic utility to emit gauge metrics in the `plugin_manager` using the labeled gauges now found in flytestdlib.
* Henceforth, a goroutine will be spun up that will create a `ResourceLevelMonitor` for each type that a plugin registers.
* Changing the existing gauge collecting utilty for FlyteWorkflow CRD objects to use the same labeled gauge.
* We may wish to combine these in the future but as their aggregations are different, we are keeping them separate for now.

## Tracking Issue
flyteorg#311

## Follow-up issue
NA
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 20, 2022
Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 20, 2022
* Added version flag in the sandbox

Signed-off-by: Yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 9, 2023
# TL;DR
Adds a generic labeled gauge for K8s plugin resources

## Type
 - [ ] Bug Fix
 - [x] Feature
 - [ ] Plugin

## Are all requirements met?

 - [x] Code completed
 - [x] Smoke tested
 - [x] Unit tests added
 - [x] Code documentation added
 - [x] Any pending items have an associated Issue

## Complete description
* We are adding a generic utility to emit gauge metrics in the `plugin_manager` using the labeled gauges now found in flytestdlib.
* Henceforth, a goroutine will be spun up that will create a `ResourceLevelMonitor` for each type that a plugin registers.
* Changing the existing gauge collecting utilty for FlyteWorkflow CRD objects to use the same labeled gauge.
* We may wish to combine these in the future but as their aggregations are different, we are keeping them separate for now.

## Tracking Issue
flyteorg#311

## Follow-up issue
NA
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
@cosmicBboy cosmicBboy deleted the bump-console branch December 7, 2023 23:34
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Apr 30, 2024
* Added version flag in the sandbox

Signed-off-by: Yuvraj <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
* Added version flag in the sandbox

Signed-off-by: Yuvraj <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
* Added version flag in the sandbox

Signed-off-by: Yuvraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants