Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated flyte sandbox docker image to use flyte-dep & flyte-core #2446

Merged
merged 11 commits into from
May 19, 2022
Merged

Migrated flyte sandbox docker image to use flyte-dep & flyte-core #2446

merged 11 commits into from
May 19, 2022

Conversation

yindia
Copy link
Contributor

@yindia yindia commented May 4, 2022 •
edited
Loading

Screenshot 2022-05-06 at 6 57 56 PM

Screenshot 2022-05-06 at 6 58 33 PM

Screenshot 2022-05-06 at 6 59 02 PM

@yindia yindia requested review from EngHabu, kumare3 and samhita-alla May 4, 2022 17:37
@yindia yindia marked this pull request as draft May 4, 2022 19:35
@yindia yindia force-pushed the sandbox-docs-fix branch from 24b2186 to 3714d33 Compare May 4, 2022 20:44
@yindia yindia force-pushed the sandbox-docs-fix branch from d3c1d90 to abc1f5c Compare May 6, 2022 12:29
fix sandbox helm values
dbc3c05 
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia marked this pull request as ready for review May 6, 2022 12:35
@yindia yindia changed the title Added sandbox deployment docs Migrated flyte sandbox docker image to use flyte-dep & flyte-core May 6, 2022
docs fixes
4649a5e 
Signed-off-by: Yuvraj <[email protected]>
make helm
318456a 
Signed-off-by: Yuvraj <[email protected]>
EngHabu
EngHabu reviewed May 6, 2022
View reviewed changes
rsts/deployment/sandbox.rst Outdated Show resolved Hide resolved
rsts/deployment/sandbox.rst Outdated Show resolved Hide resolved
rsts/deployment/sandbox.rst Outdated Show resolved Hide resolved
more changes
df00046 
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia requested a review from EngHabu May 7, 2022 16:01
more changes
baa131f 
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia force-pushed the sandbox-docs-fix branch from 80a4e0c to baa131f Compare May 7, 2022 16:32
Yuvraj added 2 commits May 10, 2022 18:41
@yindia yindia mentioned this pull request May 10, 2022
Merged
EngHabu
EngHabu reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Almost there I believe...

rsts/deployment/sandbox.rst Show resolved Hide resolved
rsts/deployment/sandbox.rst Show resolved Hide resolved
rsts/deployment/sandbox.rst Outdated Show resolved Hide resolved
@yindia yindia force-pushed the sandbox-docs-fix branch from 0ad48fc to deb1239 Compare May 16, 2022 14:02
fix formating
c15f16e 
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia force-pushed the sandbox-docs-fix branch from f2d39c1 to c15f16e Compare May 16, 2022 15:22
@yindia yindia requested a review from EngHabu May 16, 2022 15:32
Yuvraj added 2 commits May 16, 2022 21:03
more changes
929b8b7 
Signed-off-by: Yuvraj <[email protected]>
fix formating
00c1f9f 
Signed-off-by: Yuvraj <[email protected]>
@EngHabu EngHabu merged commit cc12726 into master May 19, 2022
@EngHabu EngHabu deleted the sandbox-docs-fix branch May 19, 2022 15:55
@yindia yindia mentioned this pull request Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EngHabu EngHabu EngHabu approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3

@samhita-alla samhita-alla Awaiting requested review from samhita-alla

@pmahindrakar-oss pmahindrakar-oss Awaiting requested review from pmahindrakar-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yindia @EngHabu @samhita-alla