-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shields and header in README (Close #3017) #3018
Conversation
Signed-off-by: 3t8 <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
<a href="https://github.com/flyteorg/flyte/commits"> | ||
<img src="https://img.shields.io/github/commit-activity/w/flyteorg/flyte.svg" alt="Commit Activity" /></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatting somehow doesn't look clean. Is the anchor tag on the new line the reason for underscores?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, everything before the closing anchor tag is interpreted as text, including newlines. By default the style is underlined and we cannot change that on github.
In alternative we could put everything on the same line
<a href="https://github.com/flyteorg/flyte/commits"><img src="https://img.shields.io/github/commit-activity/w/flyteorg/flyte.svg" alt="Commit Activity" /></a>
but I thought it would make more sense to have the img
tag on a new line even if the closing anchor doesn't have the same indentation as the opening one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try replacing anchor tags with https://stackoverflow.com/a/61072867/9695360 and check if this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't be able to keep them centered if we go for markdown. The closest solution to mixing both is something similar to this https://stackoverflow.com/questions/29368902/how-can-i-wrap-my-markdown-in-an-html-div but the only difference would be using markdown image tags instead of html img
tags. They all still have to stay on one line
Signed-off-by: 3t8 <[email protected]>
Congrats on merging your first pull request! 🎉 |
Tracking issue
#3017
Describe your changes
a
tags to prevent unwanted underline on hoverCheck all the applicable boxes