Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask operator #3145

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Conversation

bstadlbauer
Copy link
Member

Tracking issue

#427

Describe your changes

Adds:

  • dask operator deployment to the helm chart
  • Notes about dask to the top-level README.md
  • Description on how to setup dask backend plugin

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Do I also need to add the dask operator deployment to kustomize?

Signed-off-by: Bernhard Stadlbauer <[email protected]>
Signed-off-by: Bernhard Stadlbauer <[email protected]>
Signed-off-by: Bernhard Stadlbauer <[email protected]>
@bstadlbauer
Copy link
Member Author

@hamersaw Is there also a need to a kustomize deployment for the dask operator?

@hamersaw
Copy link
Contributor

@hamersaw Is there also a need to a kustomize deployment for the dask operator?

I believe we are deprecating kustomize support, so I do not think it is necessary.

cc @eapolinario can you confirm?

@eapolinario
Copy link
Contributor

@hamersaw Is there also a need to a kustomize deployment for the dask operator?

I believe we are deprecating kustomize support, so I do not think it is necessary.

cc @eapolinario can you confirm?

That's correct. We talked about it, so no need to update the kustomize deployments to support this.

@wild-endeavor wild-endeavor changed the title Add dask operator #minor Add dask operator Jan 11, 2023
charts/flyte-core/values-eks.yaml Outdated Show resolved Hide resolved
charts/flyte-core/values.yaml Outdated Show resolved Hide resolved
eapolinario and others added 4 commits January 11, 2023 13:19
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 782fe74 into flyteorg:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants