Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build flyte-binary image during sandbox-bundled build #3216

Merged
merged 1 commit into from
Jan 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions docker/sandbox-bundled/Makefile
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
define FLYTE_BINARY_BUILD
mkdir -p images/tar/$(1)

docker buildx build \
--build-arg FLYTECONSOLE_VERSION=$(FLYTECONSOLE_VERSION) \
--platform linux/$(1) \
--tag flyte-binary:sandbox \
--output type=docker,dest=images/tar/$(1)/flyte-binary.tar \
../..

endef

.PHONY: flyte
flyte: FLYTE_BINARY_VERSION := latest
flyte: FLYTECONSOLE_VERSION := latest
flyte:
mkdir -p images/tar/amd64
docker pull --platform linux/amd64 \
ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION)
docker tag ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION) \
flyte-binary:sandbox
docker save --output images/tar/amd64/flyte-binary.tar flyte-binary:sandbox
docker rmi flyte-binary:sandbox

mkdir -p images/tar/arm64
docker pull --platform linux/arm64 \
ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION)
docker tag ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION) \
flyte-binary:sandbox
docker save --output images/tar/arm64/flyte-binary.tar flyte-binary:sandbox
docker rmi flyte-binary:sandbox
$(foreach arch,amd64 arm64,$(call FLYTE_BINARY_BUILD,$(arch)))

.PHONY: manifests
manifests:
Expand Down