Add ip alb ingress target type for EKS values #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Ferdinand von den Eichen <[email protected]>
fvde
force-pushed
the
add-alb-ingress-target-ip-for-eks-values
branch
from
9143fe5 to
e5acf64
Compare
|
cc: @jeevb |
|
Unfortunately, we are unable to test this change right now. But we can test/approve once the Flyte development cluster is reconfigured to use ALB for ingress, by the end of the week. |
davidmirror-ops
previously approved these changes
Feb 15, 2023
|
@jeevb Are we ok to merge this? |
|
Yes. This should be good! Thanks @fvde! |
jeevb
previously approved these changes
Feb 21, 2023
|
The failed test seems legit in the sense that they seem to reference the eks area of the test suite. I'm not too proficient with Go, so I might need some help here... |
|
You will need to run the follow make target and commit the changes: Line 37 in 7f66e47 |
Signed-off-by: Ferdinand von den Eichen <[email protected]>
|
Done, could you retest? |
jeevb
approved these changes
Mar 6, 2023
wild-endeavor
approved these changes
Mar 6, 2023
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
This change does not close an open Issue per se, but to I had to make this change in my config to get the ALB creation to work at all. See this Slack Thread for additional background:
https://flyte-org.slack.com/archives/C01P3B761A6/p1671215817793359
Describe your changes
Route traffic for EKS deployment directly from ALB to pods. For details: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/ingress/annotations/#target-type
alb.ingress.kubernetes.io/target-type: ipCheck all the applicable boxes
Screenshots
Note to reviewers