-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto-docs: Compile-time and Runtime PodTemplates #3391
Conversation
Signed-off-by: Eduardo Apolinario <[email protected]>
A few thoughts here: nit: stick to uniformity on |
Weird, sphinx thinks the subheader hierarchy is off https://github.com/flyteorg/flyte/actions/runs/4320063811/jobs/7539915673#step:5:121 Can you try using Also, we should also add a new example in flytesnacks under the Kubernetes Pod integration |
that's not the correct place as these will apply everywhere - ContainerTask, ShellTask, Dask / Ray plugins, etc |
In that case, thoughts on where this should go? |
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
How about we add those in each relevant section? For example: @cosmicBboy , what do you think? |
Here's how the little graph renders in the docs: |
…r/usage/restructuredtext/basics.html#sections Signed-off-by: eduardo apolinario <[email protected]>
|
||
If you have the default PodTemplate defined in the ``flyte`` namespace | ||
Example 1: Runtime PodTemplate and K8s Plugin Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of these examples may be redundant. Example 3 covers Example 1 and Example 2 right? OK to leave all as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just want to make it clear that we can mix and match (up to a point obviously, since one cannot use a default Runtime PodTemplate and a named one at the same time).
|
||
Set the ``default-pod-template-name`` in FlytePropeller | ||
======================================================== | ||
-------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Set the default-pod-template-name in FlytePropeller
above this line is only required when using a default PodTemplate and not if it is set in the task decorator. Does it make sense to make this distinction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to add a little blurb explaining the difference between the default Runtime PodTemplate and a named one.
|
||
The term compile-time here refers to the fact that the pod template definition is part of the `TaskSpec <https://docs.flyte.org/projects/flyteidl/en/latest/protos/docs/admin/admin.html#ref-flyteidl-admin-taskclosure>`__. | ||
|
||
Runtime PodTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should explicitly say that the default-pod-template-name
is used unless it is overridden by the pod-template-name
in the task decorator. Only one may be applied. Not sure where is the best fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
Signed-off-by: eduardo apolinario <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to read in case (1) is active and FlytePropeller is building a Pod where (2) was used as part of the definition of the task, then only the values of the PodTemplate mentioned in (2) will be used to build the Pod.
multiple times to understand. Might consider rewording? If not, OK too.
Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: eduardo apolinario <[email protected]>
* Proto-docs: client-side pod templates Signed-off-by: Eduardo Apolinario <[email protected]> * In between change Signed-off-by: eduardo apolinario <[email protected]> * Compile-time versus Runtime PodTemplates Signed-off-by: eduardo apolinario <[email protected]> * Change top-level heading to match https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections Signed-off-by: eduardo apolinario <[email protected]> * Explain the difference between the two types of Runtime PodTemplates Signed-off-by: eduardo apolinario <[email protected]> * Disambiguate the evaluation precedence of Runtime PodTemplates. Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Nathan Papapietro <[email protected]>
Tracking issue
fixes #3385
Describe your changes
Documentation for Compile-time and Runtime PodTemplates feature.
Check all the applicable boxes
Note to reviewers