Update RFC process #3460
Merged
Update RFC process #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Espejo <[email protected]>
cosmicBboy
reviewed
Mar 16, 2023
rfc/README.md
Outdated
|
|
||
| [](https://mermaid-js.github.io/mermaid-live-editor/edit##eyJjb2RlIjoiZ3JhcGggVERcbiAgICBBW1N0YXJ0XSAtLT58V3JpdGUgUkZDfCBCKE9wZW4gYSBQUilcbiAgICBCIC0tPiBDe1BSIFJldmlld31cbiAgICBDIC0tPnxBcHByb3ZlZHwgRFtNZXJnZV1cbiAgICBDIC0tPnxGZWVkYmFja3wgQ1xuICAgIEMgLS0-fFJlamVjdGVkfCBGW1BSIENsb3NlXSIsIm1lcm1haWQiOiJ7XG4gIFwidGhlbWVcIjogXCJkZWZhdWx0XCJcbn0iLCJ1cGRhdGVFZGl0b3IiOmZhbHNlLCJhdXRvU3luYyI6dHJ1ZSwidXBkYXRlRGlhZ3JhbSI6ZmFsc2V9) | ||
| - Gathering feedback from team or community members first, to confirm that the changes will indeed be useful | ||
| - Starting a Discussion at the [RFC Incubator](https://github.com/flyteorg/flyte/discussions/new?category=rfc-incubator) to gauge interest. |
There was a problem hiding this comment.
can we add something here (or somether below maybe) about how to transition a RFC Incubator post to the official RFC pipeline?
There was a problem hiding this comment.
added some lines, wdyt?
Signed-off-by: David Espejo <[email protected]>
bstadlbauer
previously approved these changes
Mar 24, 2023
fg91
previously approved these changes
Mar 24, 2023
|
|
||
| RFCs must be introduced as a `.md` (Markdown-format) file in a PR into the flyte repo. Details of the location to store them can be [found below](#Where-to-store-RFCs). | ||
| The Flyte repo on GitHub has an RFC folder with 3 directories: | ||
| - **Core language:** proposals to `FlyteIdl` that change the wire-format in any way are considered significant changes that require revision and approval. |
There was a problem hiding this comment.
An example of what change to flyteidl constitutes or doesn't constitute a change of the wire-format might be nice.
There was a problem hiding this comment.
Great question. @kumare3 / @cosmicBboy do you have an idea?
rfc/README.md
Outdated
| * The proposal will be discussed as much as possible in the RFC pull request directly. Any outside discussion will be summarized in the comment thread | ||
| * When deemed "ready", a maintainer or TSC member will propose a "motion for Final Comment Period (FCP)" along with a disposition of the outcome (merge, close, or postpone). This step is taken when enough discussions of the tradeoffs have taken place and the community is in a position to make a decision. | ||
| * The proposal enters FCP unless there's any objection (lazy consensus) | ||
| * The Final Comment Period will last 7 days. If there's no objection, the FCP can close early |
There was a problem hiding this comment.
Suggested change
| * The Final Comment Period will last 7 days. If there's no objection, the FCP can close early | |
| * The Final Comment Period will last 7 days. If there's no objection, the FCP can close early. |
rfc/RFC-Process-diagram.png
Outdated
There was a problem hiding this comment.
Is this file still needed? Only v2 is used in the text.
Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]> Signed-off-by: David Espejo <[email protected]>
davidmirror-ops
dismissed stale reviews from fg91, bstadlbauer, and cosmicBboy
via
23c1afd
Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]> Signed-off-by: David Espejo <[email protected]>
Signed-off-by: David Espejo <[email protected]>
…ops/flyte into rfc-process-updates Update local branch
cosmicBboy
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Introduces the following changes to the RFC process:
Check all the applicable boxes