-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single task execution docs #354
Conversation
my_task = _task.SdkTask.fetch("my_flyte_project", "production", "workflows.my_task", "abc123") # project, domain, name, version | ||
|
||
my_task_exec = my_task.launch(project="my_other_project", domain="development", inputs={'plant': 'philodendron'}) | ||
my_task_exec.wait_for_completion() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can Admin withstand potentially tens of thousands of these polling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should move to websockets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why websockets? These should be converted to long poll if needed. But we don’t need it at all I feel. This is a usecase only for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with questions
Signed-off-by: Haytham Abuelfutuh <[email protected]>
* revert Signed-off-by: Katrina Rogan <[email protected]> * lint Signed-off-by: Katrina Rogan <[email protected]>
Current Behavior is to fetch only 10 launch-plans per workflow . This causes issues for users who have > 10 launch-plans with no way of fetching/triggering them via the UI. Signed-off-by: Anmol Khurana <[email protected]>
* update launch_plan.go add links to activating and deactivating a launch plan Signed-off-by: SmritiSatyanV [email protected] * render correctly Fix rendering Signed-off-by: SmritiSatyanV [email protected]
* Improve demystifying GKE spot node preemtion Signed-off-by: Bernhard Stadlbauer <[email protected]> * Add test Signed-off-by: Bernhard Stadlbauer <[email protected]> --------- Signed-off-by: Bernhard Stadlbauer <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
* revert Signed-off-by: Katrina Rogan <[email protected]> * lint Signed-off-by: Katrina Rogan <[email protected]>
* Improve demystifying GKE spot node preemtion Signed-off-by: Bernhard Stadlbauer <[email protected]> * Add test Signed-off-by: Bernhard Stadlbauer <[email protected]> --------- Signed-off-by: Bernhard Stadlbauer <[email protected]>
* update launch_plan.go add links to activating and deactivating a launch plan Signed-off-by: SmritiSatyanV [email protected] * render correctly Fix rendering Signed-off-by: SmritiSatyanV [email protected]
* update launch_plan.go add links to activating and deactivating a launch plan Signed-off-by: SmritiSatyanV [email protected] * render correctly Fix rendering Signed-off-by: SmritiSatyanV [email protected]
* update launch_plan.go add links to activating and deactivating a launch plan Signed-off-by: SmritiSatyanV [email protected] * render correctly Fix rendering Signed-off-by: SmritiSatyanV [email protected]
No description provided.