Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render flyte-sandbox manifests to pick up any changes to flyte-binary chart during automation #3561

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Render flyte-sandbox manifests to pick up any changes to flyte-binary chart during automation #3561

merged 1 commit into from
Mar 31, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Mar 31, 2023

No description provided.

@jeevb jeevb marked this pull request as draft March 31, 2023 16:39
@jeevb jeevb marked this pull request as ready for review March 31, 2023 16:41
@jeevb jeevb changed the title Render flyte-sandbox manifests to pick up any changes during automation Render flyte-sandbox manifests to pick up any changes to flyte-binary chart during automation Mar 31, 2023
wild-endeavor
wild-endeavor approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still think we should run a check to see if there's a diff and fail but we can add that later.

@jeevb jeevb merged commit 4bc87b9 into master Mar 31, 2023
@jeevb jeevb deleted the jeev/render-sandbox-manifests-on-release branch March 31, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes

@eapolinario eapolinario Awaiting requested review from eapolinario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeevb @wild-endeavor