Adapt execution tags RFC with results from contributor's sync discuss… #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg91
commented
May 25, 2023
|
|
||
| Two approaches |
There was a problem hiding this comment.
In the previous contributors synch we discussed that option 1 is preferable since we don't want to impose on users which label keys are considered special in their domain.
|
+1 |
kumare3
approved these changes
May 25, 2023
…ions Signed-off-by: Fabio Grätz <[email protected]>
fg91
force-pushed
the
adapt-flyte-tags-rfc
branch
from
07a4796 to
6d78028
Compare
|
@kumare3 can this be merged? Don't have perms. |
eapolinario
pushed a commit
that referenced
this pull request
Jul 20, 2023
* [Proposal]: Flyte System Tags and metadata Signed-off-by: Ketan Umare <[email protected]> * added images Signed-off-by: Ketan Umare <[email protected]> * Adapt execution tags RFC with results from contributor's sync discussions (#3727) * update doc Signed-off-by: Kevin Su <[email protected]> * update doc Signed-off-by: Kevin Su <[email protected]> * Update rfc/system/0001-flyte-execution-tags.md Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]> Signed-off-by: Kevin Su <[email protected]> * Update rfc/system/0001-flyte-execution-tags.md Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]> Signed-off-by: Kevin Su <[email protected]> * Update rfc/system/0001-flyte-execution-tags.md Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]> Signed-off-by: Kevin Su <[email protected]> * Update rfc/system/0001-flyte-execution-tags.md Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]> Signed-off-by: Kevin Su <[email protected]> * update doc Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Fabio M. Graetz, Ph.D <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
@kumare3 this PR amends the system tags RFC according to what we discussed in the last contributors sync.