Fixed bug for incorrect name

[Virtual4087]

Closes #4174

Tracking issue

Describe your changes

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Screenshots

Note to reviewers

[welcome]

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

• Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
• Sign off your commits (Reference: DCO Guide).

[samhita-alla]

@kumare3, do you think this PR can be merged?

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0ca2d22) 58.95% compared to head (31a0d69) 59.30%.

❗ Current head 31a0d69 differs from pull request most recent head 705044c. Consider uploading reports for the commit 705044c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4175      +/-   ##
==========================================
+ Coverage   58.95%   59.30%   +0.34%     
==========================================
  Files         621      552      -69     
  Lines       52932    39798   -13134     
==========================================
- Hits        31206    23601    -7605     
+ Misses      19229    13864    -5365     
+ Partials     2497     2333     -164     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...pkg/manager/impl/validation/execution_validator.go	73.80% <100.00%> (+1.73%)	⬆️

... and 557 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kumare3]

can we not copy paste the regex, instead print the regex value itself.
Also, update the unit tests

[Virtual4087]

umm is it okay now?

[kumare3]

Lgtm

[Virtual4087]

while you're at it can you add the hacktoberfest label as well?

[Virtual4087]

can you share the test location? I'll update it

[Virtual4087]

I'm not familiar with these tests so i couldn't find it but the changes work well. The test just needs to be updated

[Virtual4087]

i think it's good now

[pingsutw]

Test is failing.

        	Error Trace:	/home/runner/work/flyte/flyte/flyteadmin/pkg/manager/impl/validation/execution_validator_test.go:45
        	Error:      	Error message not equal:
        	            	expected: "invalid name format: 12345"
        	            	actual  : "invalid name format: 12345, does not match regex '^[a-z][a-z\\-0-9]*$'"

[Virtual4087]

Ok it should work now i updated the test

[samhita-alla]

@Virtual4087, I'll add the hacktoberfest-accepted label once the PR is merged.

[Virtual4087]

I think you guys need to update the unit test for the checks to be successful. The test expects "invalid name format: 12345" but you asked to make it ""invalid name format: 12345, does not match regex '^[a-z][a-z\-0-9]*$'". I've also updated the tests on my branch so kindly check the pr once.

[pingsutw]

Line 173 and 176 need to be updated as well.

flyte/flyteadmin/pkg/manager/impl/validation/execution_validator_test.go

Lines 173 to 176 in 4a780c3

	assert.EqualError(t, err, "invalid a format: a_sdd")
	err = CheckValidExecutionID("asd@", "a")
	assert.NotNil(t, err)
	assert.EqualError(t, err, "invalid a format: asd@")

[Virtual4087]

Line 173 and 176 need to be updated as well.

flyte/flyteadmin/pkg/manager/impl/validation/execution_validator_test.go

Lines 173 to 176 in 4a780c3

	assert.EqualError(t, err, "invalid a format: a_sdd")
	err = CheckValidExecutionID("asd@", "a")
	assert.NotNil(t, err)
	assert.EqualError(t, err, "invalid a format: asd@")

Done

[samhita-alla]

@pingsutw, could you please review this PR now?

[pingsutw]

LGTM

[welcome]

Congrats on merging your first pull request! 🎉

[Virtual4087]

Finally