Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unmarshal attribute for expires_in for device flow auth token #4319

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

Closes #3288

Describe your changes

This is porting flyteorg/flyteidl#362 to the monorepo.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.00%. Comparing base (b6b0d61) to head (160a457).
Report is 388 commits behind head on master.

❗ Current head 160a457 differs from pull request most recent head 712dbc4. Consider uploading reports for the commit 712dbc4 to get more accurate results

Files Patch % Lines
.../clients/go/admin/deviceflow/token_orchestrator.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4319       +/-   ##
===========================================
+ Coverage   59.53%   79.00%   +19.46%     
===========================================
  Files         632       18      -614     
  Lines       53527     1300    -52227     
===========================================
- Hits        31867     1027    -30840     
+ Misses      19145      209    -18936     
+ Partials     2515       64     -2451     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 15, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor force-pushed the fix-expiry-device-auth-token branch from 5050788 to 712dbc4 Compare April 15, 2024 22:34
@wild-endeavor wild-endeavor enabled auto-merge (squash) April 15, 2024 22:44
@wild-endeavor wild-endeavor merged commit 1757750 into master Apr 15, 2024
46 checks passed
@wild-endeavor wild-endeavor deleted the fix-expiry-device-auth-token branch April 15, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] (Auth) Device flow token expiry not set correctly
2 participants