Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting running if the primary container status is not yet reported #4339

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

hamersaw
Copy link
Contributor

Tracking issue

fixes #4332

Describe your changes

If the primary container status is not found we check if the pod definition contains the containers name. In this scenario the container status has not yet been reported, but will be when it begins executing.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

NA

Note to reviewers

NA

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (ac4ec7d) 59.07% compared to head (46381e9) 59.34%.
Report is 11 commits behind head on master.

❗ Current head 46381e9 differs from pull request most recent head c6a8eee. Consider uploading reports for the commit c6a8eee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4339      +/-   ##
==========================================
+ Coverage   59.07%   59.34%   +0.26%     
==========================================
  Files         614      544      -70     
  Lines       52006    38981   -13025     
==========================================
- Hits        30723    23133    -7590     
+ Misses      18832    13568    -5264     
+ Partials     2451     2280     -171     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 75.72% <100.00%> (-2.12%) ⬇️
flyteplugins/go/tasks/plugins/k8s/ray/config.go 36.36% <ø> (+7.79%) ⬆️
flyteplugins/go/tasks/plugins/k8s/pod/plugin.go 80.41% <85.71%> (+3.78%) ⬆️
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 65.34% <77.77%> (+3.84%) ⬆️
...ytepropeller/pkg/controller/nodes/array/handler.go 70.20% <50.00%> (+0.57%) ⬆️
...g/controller/nodes/array/node_execution_context.go 62.26% <60.00%> (+2.94%) ⬆️
...lytepropeller/pkg/controller/nodes/task/handler.go 60.39% <33.33%> (+1.74%) ⬆️
flyteplugins/go/tasks/plugins/array/catalog.go 47.71% <75.00%> (+2.41%) ⬆️
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 83.68% <91.93%> (+0.30%) ⬆️

... and 543 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eapolinario
eapolinario previously approved these changes Nov 3, 2023
flyteplugins/go/tasks/plugins/k8s/pod/sidecar_test.go Outdated Show resolved Hide resolved
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw merged commit 8824341 into master Nov 7, 2023
39 checks passed
@hamersaw hamersaw deleted the bug/primary-container-status-not-reported-yet branch November 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flyte tasks may fail if containerStatus is not present for primary container fast enough
2 participants