-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding consoleUrl parameterization based on partition #4375
adding consoleUrl parameterization based on partition #4375
Conversation
Signed-off-by: Laura Lin <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. could we add a test here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4375 +/- ##
==========================================
+ Coverage 59.59% 59.99% +0.39%
==========================================
Files 632 562 -70
Lines 53621 40297 -13324
==========================================
- Hits 31954 24175 -7779
+ Misses 19146 13772 -5374
+ Partials 2521 2350 -171
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Laura Lin <[email protected]>
Signed-off-by: Laura Lin <[email protected]>
Added! |
Signed-off-by: Laura Lin <[email protected]>
Congrats on merging your first pull request! 🎉 |
Tracking issue
N/A
Describe your changes
Adds support for the Log Links for AWS gov environments instead of hard-coding to commercial
Check all the applicable boxes
Screenshots
Note to reviewers