Passthrough unique node ID in task execution ID for generating log te… #4380
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4380 +/- ##
==========================================
+ Coverage 59.11% 59.36% +0.24%
==========================================
Files 614 544 -70
Lines 52073 38989 -13084
==========================================
- Hits 30785 23147 -7638
+ Misses 18839 13562 -5277
+ Partials 2449 2280 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jeevb
force-pushed
the
jeev/child-task-node-id
branch
4 times, most recently
from
0680e1f to
b7dedc9
Compare
…mplate vars Signed-off-by: Jeev B <[email protected]>
jeevb
force-pushed
the
jeev/child-task-node-id
branch
from
b7dedc9 to
ac764a9
Compare
Signed-off-by: Jeev B <[email protected]>
| @@ -53,7 +54,7 @@ func GetLogsForContainerInPod(ctx context.Context, logPlugin tasklog.Plugin, tas | |||
| PodRFC3339FinishTime: time.Unix(finishTime, 0).Format(time.RFC3339), | |||
| PodUnixStartTime: startTime, | |||
| PodUnixFinishTime: finishTime, | |||
| TaskExecutionIdentifier: taskExecID, | |||
| TaskExecutionID: taskExecID, | |||
There was a problem hiding this comment.
Couldn’t think of issues with backward compatibility since this will only affect new log links. Maybe I’m missing something?
There was a problem hiding this comment.
I mean, the Input object becomes your interface, right? if somebody is referencing {.TaskIdentifier.Project} that will no longer resolve if I'm reading correctly, no?
There was a problem hiding this comment.
As discussed offline, the external-facing template variables remain unchanged.
Signed-off-by: Jeev B <[email protected]>
…mplate vars
Tracking issue
Describe your changes
Passes through a node's unique ID in
pluginsCore.TaskExecutionIDas the{{.NodeID}}template variable for log template links.Check all the applicable boxes
Screenshots
Note to reviewers