-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent metadata proto #4500
Agent metadata proto #4500
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4500 +/- ##
==========================================
- Coverage 59.76% 59.38% -0.38%
==========================================
Files 636 638 +2
Lines 53870 53957 +87
==========================================
- Hits 32193 32044 -149
- Misses 19146 19383 +237
+ Partials 2531 2530 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
// Secret to be passed to the agent. | ||
// Key is the name of the secret in secret manager. | ||
// Value is the actual secret value. | ||
map<string, string> secret = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make the value a message:
message Secret {
string value = 1;
// In the future:
// string encrypted_value = 2;
// string mount_path = 3;
}
Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Tracking issue
#3936
Docs link
Describe your changes
Check all the applicable boxes
Setup Process
Screenshots
Note to reviewers
Related PRs