Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent metadata proto #4500

Closed
wants to merge 8 commits into from
Closed

Agent metadata proto #4500

wants to merge 8 commits into from

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Nov 30, 2023

Tracking issue

#3936

Docs link

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 30, 2023
@pingsutw pingsutw marked this pull request as draft November 30, 2023 09:52
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (7d712de) to head (5f35e8c).
Report is 945 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4500      +/-   ##
==========================================
- Coverage   59.76%   59.38%   -0.38%     
==========================================
  Files         636      638       +2     
  Lines       53870    53957      +87     
==========================================
- Hits        32193    32044     -149     
- Misses      19146    19383     +237     
+ Partials     2531     2530       -1     
Flag Coverage Δ
unittests 59.38% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
@Future-Outlier Future-Outlier mentioned this pull request Dec 1, 2023
3 tasks
// Secret to be passed to the agent.
// Key is the name of the secret in secret manager.
// Value is the actual secret value.
map<string, string> secret = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make the value a message:

message Secret {
  string value = 1;
  // In the future:
  // string encrypted_value = 2;
  // string mount_path = 3;
}

flyteidl/protos/flyteidl/admin/agent.proto Outdated Show resolved Hide resolved
flyteidl/protos/flyteidl/admin/agent.proto Outdated Show resolved Hide resolved
flyteidl/protos/flyteidl/admin/agent.proto Outdated Show resolved Hide resolved
pingsutw and others added 4 commits December 1, 2023 11:36
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@pingsutw pingsutw closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants