Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guide #4501

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Update contribution guide #4501

merged 5 commits into from
Dec 12, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Nov 30, 2023

Describe your changes

https://flyte--4501.org.readthedocs.build/en/4501/community/contribute.html

Add an instruction on how individuals can assign issues themselves

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 30, 2023
Signed-off-by: Kevin Su <[email protected]>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91d24a9) 58.98% compared to head (2c33119) 58.98%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4501   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files         621      621           
  Lines       52483    52483           
=======================================
  Hits        30957    30957           
  Misses      19059    19059           
  Partials     2467     2467           
Flag Coverage Δ
unittests 58.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Future-Outlier Future-Outlier enabled auto-merge (squash) November 30, 2023 23:52
@Future-Outlier Future-Outlier enabled auto-merge (squash) December 3, 2023 10:36
@Future-Outlier Future-Outlier merged commit e2b1ff2 into master Dec 12, 2023
41 checks passed
@Future-Outlier Future-Outlier deleted the self-assign branch December 12, 2023 11:44
pvditt pushed a commit that referenced this pull request Dec 13, 2023
* Update contribution guide

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants