Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#4508
Describe your changes
Controller Runtime deprecated (and completely removed) the dependency injection framework it used to have (review breaking changes section here: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0). Unfortunately this breaks very silently. InjectDecoder() is the only place as far as I can tell where we rely on that functionality. When decoders are not injected, the secrets webhook fails to parse out Pods to inject secrets too.
Check all the applicable boxes
Screenshots
Before:
After:
Note to reviewers
Related PRs
PR that upgraded Controller Runtime to the breaking version: https://github.com/flyteorg/flyte/pull/4273/files