Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded list of tests #4521

Merged
merged 9 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions .github/workflows/end2end.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,25 +79,16 @@ jobs:
- name: Register P0 tests
if: ${{ inputs.priorities == 'P0' }}
run: |
for f in \
basics/basics/hello_world.py \
basics/basics/workflow.py \
basics/basics/named_outputs.py \
advanced_composition/advanced_composition/chain_entities.py \
advanced_composition/advanced_composition/dynamics.py \
advanced_composition/advanced_composition/map_task.py \
advanced_composition/advanced_composition/subworkflows.py \
data_types_and_io/data_types_and_io/dataclass.py \
data_types_and_io/data_types_and_io/structured_dataset.py ;
while read -r line;
do
pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \
register \
--project flytesnacks \
--domain development \
--image cr.flyte.org/flyteorg/flytekit:py3.11-latest \
--version ${{ env.FLYTESNACKS_VERSION }} \
flytesnacks/examples/$f;
done
flytesnacks/$line;
done < flytesnacks/flyte_tests.txt
- name: Register all flytesnacks examples
if: ${{ inputs.priorities != 'P0' }}
uses: unionai/[email protected]
Expand Down
23 changes: 7 additions & 16 deletions .github/workflows/single-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: '1.19'
go-version: "1.19"
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
Expand Down Expand Up @@ -129,8 +129,8 @@ jobs:
sandbox-bundled-functional-tests:
runs-on: ubuntu-latest
env:
FLYTESNACKS_PRIORITIES: 'P0'
FLYTESNACKS_VERSION: ''
FLYTESNACKS_PRIORITIES: "P0"
FLYTESNACKS_VERSION: ""
timeout-minutes: 20
needs: [build-and-push-single-binary-image]
steps:
Expand Down Expand Up @@ -164,7 +164,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.11'
python-version: "3.11"
- uses: unionai/[email protected]
- name: Setup sandbox
run: |
Expand Down Expand Up @@ -193,25 +193,16 @@ jobs:
# ref: ${{ env.FLYTESNACKS_VERSION }}
- name: Register specific tests
run: |
for f in \
basics/basics/hello_world.py \
basics/basics/workflow.py \
basics/basics/named_outputs.py \
advanced_composition/advanced_composition/chain_entities.py \
advanced_composition/advanced_composition/dynamics.py \
advanced_composition/advanced_composition/map_task.py \
advanced_composition/advanced_composition/subworkflows.py \
data_types_and_io/data_types_and_io/dataclass.py \
data_types_and_io/data_types_and_io/structured_dataset.py ;
while read -r line;
do
pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \
register \
--project flytesnacks \
--domain development \
--image cr.flyte.org/flyteorg/flytekit:py3.11-latest \
--version ${{ env.FLYTESNACKS_VERSION }} \
flytesnacks/examples/$f;
done
flytesnacks/$line;
done < flytesnacks/flyte_tests.txt
- name: End2End
run: |
make end2end_execute
Expand Down
6 changes: 2 additions & 4 deletions docs/integrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,12 @@ Data is automatically marshalled and unmarshalled in and out of the plugin. User
{py:class}`~flytekit.core.base_task.PythonTask` API defined in Flytekit.

Flytekit Plugins are lazily loaded and can be released independently like libraries. We follow a convention to name the
plugin like `flytekitplugins-*`, where * indicates the package to be integrated into Flytekit. For example
plugin like `flytekitplugins-*`, where \* indicates the package to be integrated into Flytekit. For example
`flytekitplugins-papermill` enables users to author Flytekit tasks using [Papermill](https://papermill.readthedocs.io/en/latest/).

You can find the plugins maintained by the core Flyte team [here](https://github.com/flyteorg/flytekit/tree/master/plugins).
:::


## Native Backend Plugins

Native Backend Plugins are the plugins that can be executed without any external service dependencies because the compute is
Expand Down Expand Up @@ -83,7 +82,6 @@ orchestrated by Flyte itself, within its provisioned Kubernetes clusters.

(external_service_backend_plugins)=


## External Service Backend Plugins

As the term suggests, external service backend plugins relies on external services like
Expand Down Expand Up @@ -138,7 +136,6 @@ Flyte uses Kustomize to generate the the deployment configuration which can be l

::::


## Custom Container Tasks

Because Flyte uses executable docker containers as the smallest unit of compute, you can write custom tasks with the
Expand Down Expand Up @@ -208,6 +205,7 @@ flytesnacks/examples/athena_plugin/index
flytesnacks/examples/aws_batch_plugin/index
flytesnacks/examples/hive_plugin/index
flytesnacks/examples/mmcloud_plugin/index
flytesnacks/examples/sensor/index
flytesnacks/examples/snowflake_plugin/index
flytesnacks/examples/databricks_plugin/index
flytesnacks/examples/bigquery_plugin/index
Expand Down
Loading