fastcache should not cache lookup on node skip #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4524 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 620 620
Lines 52458 52458
=======================================
+ Hits 30900 30901 +1
+ Misses 19091 19090 -1
Partials 2467 2467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rammer <[email protected]>
pingsutw
approved these changes
Dec 4, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes #4384
Why are the changes needed?
Currently there will be a cache lookup failure when nodes are skipped. This is because the node inputs cannot be resolved, caused by an upstream node in the
failedphase for example.What changes were proposed in this pull request?
If a node is in the
predicatePhaseskipafter thepreexecutefunction this means that the node should be evaluated. We now predicate the fastcache cache lookup on not being in the skip phase, meaning the cache lookup will not be performed.How was this patch tested?
Tested using the
Setup process
NA
Screenshots
NA
Check all the applicable boxes
Related PRs
NA
Docs link
NA