Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken link from Understand How Flyte Handles Data page (for new monodocs site) #4547

Closed
wants to merge 3 commits into from

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Dec 7, 2023

Tracking issue

Re-applies the change in #4518.

Why are the changes needed?

The change in #4518 was made after the monodocs branch was created, so we need to bring that change over now that the monodocs PR has been merged.

What changes were proposed in this pull request?

Removes broken link from "Bringing in Your Own Datastores for Raw Data" section of "Understand How Flyte Handles Data" docs page.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#4518

Docs link

https://flyte--4547.org.readthedocs.build/en/4547/concepts/data_management.html#bringing-in-your-own-datastores-for-raw-data

Signed-off-by: nikki everett <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (398e5cb) 59.03% compared to head (1b09f49) 59.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4547      +/-   ##
==========================================
+ Coverage   59.03%   59.41%   +0.37%     
==========================================
  Files         622      440     -182     
  Lines       52682    35306   -17376     
==========================================
- Hits        31102    20977   -10125     
+ Misses      19098    12735    -6363     
+ Partials     2482     1594     -888     
Flag Coverage Δ
unittests 59.41% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 15, 2023
@neverett
Copy link
Contributor Author

The remote and local branches have diverged too much to reconcile, so I made a new branch to apply this change and opened this PR: #4757

@neverett neverett closed this Jan 22, 2024
@neverett neverett deleted the nikki-remove-link-monodocs branch August 27, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants