Add flyin plugin to monodocs integrations page #4582
Conversation
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
the
size:XS
neverett
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4582 +/- ##
==========================================
- Coverage 58.98% 58.97% -0.02%
==========================================
Files 621 621
Lines 52483 52483
==========================================
- Hits 30958 30951 -7
- Misses 19058 19065 +7
Partials 2467 2467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks for the PR @neverett !
I am okay with merging this first to unblock flyteorg/flytesnacks#1314. I left a comment about improving the workflow moving forward.
| @@ -210,4 +212,5 @@ flytesnacks/examples/snowflake_plugin/index | |||
| flytesnacks/examples/databricks_plugin/index | |||
| flytesnacks/examples/bigquery_plugin/index | |||
| flytesnacks/examples/airflow_plugin/index | |||
| flytesnacks/examples/flyin_plugin/index | |||
There was a problem hiding this comment.
@cosmicBboy The workflow for adding a new plugin example is a bit involved. We have to update flyte's TOC with an example that does not exist and then add the example to flytesnacks.
Can this TOC be auto generated from flytesnacks during the doc build process? (Implementation-wise it would auto generate a TOC file that we .. include:: in this spot.)
|
hey @neverett, I'm actually working on a PR to changes the toctree such that monodocs uses the integrations, userguide, and tutorial toctrees that are in flytesnacks, so that we don't have to make updates to both repos when adding new examples, PR incoming! |
|
we can merge this to unblock the flytesnacks PR |
Signed-off-by: nikki everett <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Why are the changes needed?
Currently, flyteorg/flytesnacks#1314 is failing the monodocs build step because it adds a new plugin page that has not been added to the integrations TOC.
What changes were proposed in this pull request?
Adds the flyin plugin index link to the integrations docs config page.
Check all the applicable boxes
Related PRs
flyteorg/flytesnacks#1314
Docs link
TBD