-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-generate toctree from flytesnacks index.md docs #4587
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c533167
auto-generate toctree from flytesnacks index.md docs
cosmicBboy d61b209
fix environment_setup ref
cosmicBboy 3eee3e1
make ListTableToc more generic
cosmicBboy 1adfb16
Merge branch 'master' into auto-gen-toc
cosmicBboy eed7d6d
Merge branch 'master' into auto-gen-toc
cosmicBboy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
flytesnacks
adds another ref indocs/tutorials.md
, we would still need to add a new entry inflyte
. If this is true, can we document this somewhere?An alternative is to parse
tutorials.md
and friends for anything that is<SINGLE_WORD>
and replace it with<flytesnacks/SINGLE_WORD>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no we don't, the
weather_forecasting
page is really the only exception to this (tbh it should really be an example). In general all the docs should follow the<auto_examples/...
pattern above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
weather_forecasting
andenvironment_setup
having this pattern. For my understanding, if one adds a<mlops_setup>
indocs/tutorials.md
do we need to add the following toREPLACE_PATTERNS
?Or we want this to be an anti-pattern and so this should not happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is an anti-pattern that we need to fix more systematically.
Eventually we can can specify the
list-table-toc
directive in these files and assume that all refs in these directives follow the pattern<flytesnacks/examples/...>
. Any ref outside oflist-table-toc
won't be treated specially.Basically any entries listed under
list-table-toc
intutorials
,userguide
, andintegrations
ought to follow the example template described here: https://docs.flyte.org/projects/cookbook/en/latest/contribute.html