Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run single-binary gh workflows on all PRs #4589

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

Since single-binary is a fundamental part of the dev experience, let's get more coverage by running functional tests on every PR.

What changes were proposed in this pull request?

Run single-binary functional tests on all PRs.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5ea1c8) 58.27% compared to head (fd5a790) 58.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4589      +/-   ##
==========================================
+ Coverage   58.27%   58.99%   +0.71%     
==========================================
  Files         547      621      +74     
  Lines       48100    52498    +4398     
==========================================
+ Hits        28029    30969    +2940     
- Misses      17781    19061    +1280     
- Partials     2290     2468     +178     
Flag Coverage Δ
unittests 58.99% <ø> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2023
@eapolinario eapolinario enabled auto-merge (squash) December 13, 2023 16:50
@eapolinario eapolinario merged commit 2b75785 into master Dec 13, 2023
45 checks passed
@eapolinario eapolinario deleted the run-single-binary-on-PRs branch December 13, 2023 17:10
@Future-Outlier Future-Outlier mentioned this pull request Dec 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants