Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add cleanup non recoverable pod statuses #4607

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Dec 15, 2023

Tracking issue

Closes: #4198

Why are the changes needed?

Pods hang indefinitely

What changes were proposed in this pull request?

Cleanup pods on failure

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Dec 15, 2023
@pvditt pvditt force-pushed the feature/add-cleanup-non-recoverable-pod-statuses branch from 4bd6fc8 to 28a4dd1 Compare December 15, 2023 21:42
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b562536) 59.02% compared to head (2d76091) 59.04%.

Files Patch % Lines
...lyteplugins/go/tasks/pluginmachinery/core/phase.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4607      +/-   ##
==========================================
+ Coverage   59.02%   59.04%   +0.01%     
==========================================
  Files         622      622              
  Lines       52685    52687       +2     
==========================================
+ Hits        31098    31109      +11     
+ Misses      19105    19098       -7     
+ Partials     2482     2480       -2     
Flag Coverage Δ
unittests 59.04% <36.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw merged commit 6c6656c into master Dec 19, 2023
44 of 45 checks passed
@hamersaw hamersaw deleted the feature/add-cleanup-non-recoverable-pod-statuses branch December 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants