-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore cache variables #4618
Ignore cache variables #4618
Conversation
…lation purposes Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4618 +/- ##
=======================================
Coverage 59.03% 59.04%
=======================================
Files 622 622
Lines 52682 52685 +3
=======================================
+ Hits 31103 31108 +5
Misses 19097 19097
+ Partials 2482 2480 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Would it make sense to automatically evict task output for previous cached results for a task given the cache_ignore_input_vars changes? Can see it both ways as this is a little different than updating the params of a task.
(outside the context of the above PR but thinking as part of cache deletion work)
Tracking issue
Iterating on PR - #4324
Why are the changes needed?
Refer to linked PR.
What changes were proposed in this pull request?
Updated to disable input vars in the
HashLiteralMap
function. This makes it compatible with the existingmaptask
implementation which uses the async catalog client.How was this patch tested?
Refer to linked PR.
Setup process
Refer to linked PR.
Screenshots
Refer to linked PR.
Check all the applicable boxes
Related PRs
#4324
Docs link
Refer to linked PR.