Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 100 kilobyte max error message size #4631

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

hamersaw
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

This MaxErrorMessageLength value is now used to truncate ArrayNode errors, since it was actually 100MB this resulted in potentially large FlyteWorkflow CRs.

What changes were proposed in this pull request?

Correctly computing the 100KB to B conversion.

How was this patch tested?

NA

Setup process

NA

Screenshots

NA

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Daniel Rammer <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2aab954) 59.02% compared to head (0f7d9fe) 59.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4631   +/-   ##
=======================================
  Coverage   59.02%   59.02%           
=======================================
  Files         622      622           
  Lines       52816    52816           
=======================================
+ Hits        31174    31175    +1     
+ Misses      19151    19150    -1     
  Partials     2491     2491           
Flag Coverage Δ
unittests 59.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw merged commit 853ebe4 into master Dec 22, 2023
45 checks passed
@hamersaw hamersaw deleted the bug/max-error-message-length branch December 22, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants