Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing slash to compile make target #4648

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add trailing slash to compile make target #4648

merged 1 commit into from
Mar 28, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

Closes #4639

Why are the changes needed?

Minor fix. I couldn't find anything about the guarantees for the bin directory, so adding a bit of defensive programming.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81ce71e) 58.11% compared to head (a1394e1) 58.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4648   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files         626      626           
  Lines       53815    53815           
=======================================
  Hits        31277    31277           
  Misses      20036    20036           
  Partials     2502     2502           
Flag Coverage Δ
unittests 58.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) February 28, 2024 21:20
@eapolinario eapolinario disabled auto-merge March 28, 2024 20:33
@eapolinario eapolinario merged commit d4929cf into master Mar 28, 2024
45 checks passed
@eapolinario eapolinario deleted the fix-bin-path branch March 28, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flyte Makefile missing / in mv command
2 participants