Updating ArrayNode ExternalResourceInfo ID #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
size:M
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4677 +/- ##
==========================================
- Coverage 58.12% 58.10% -0.02%
==========================================
Files 626 626
Lines 53815 53834 +19
==========================================
+ Hits 31278 31280 +2
- Misses 20035 20048 +13
- Partials 2502 2506 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
pingsutw
previously approved these changes
Jan 5, 2024
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
size:L
pingsutw
approved these changes
Jan 5, 2024
katrogan
pushed a commit
that referenced
this pull request
Jan 12, 2024
* updating externalResourceID Signed-off-by: Daniel Rammer <[email protected]> * fix unit tests Signed-off-by: Daniel Rammer <[email protected]> * generate event recorder mocks Signed-off-by: Daniel Rammer <[email protected]> * correctly setting task id in events Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
The external resource ID may be used in other locations to link to the executing entity. If this is incorrect, then it is impossible to determine the actual k8s resource.
What changes were proposed in this pull request?
Correcty setting the ExternalResourceInfo ExternalID field to the Pod name for each subtask.
How was this patch tested?
local / cloud / etc
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA