Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dns policy for sandbox buildkit instance to ClusterFirstWithHo… #4678

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Jan 4, 2024

…stNet

Why are the changes needed?

Buildkitd instance currently cannot resolve in-cluster DNS entries such as https://flyte-sandbox-minio.flyte:9000. This change fixes it.

How was this patch tested?

  • Ensured that local build/push via image spec is working as intended.
  • Ensured that in-cluster DNS entries can be resolved from within the buildkitd instance.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2024
@jeevb jeevb marked this pull request as ready for review January 4, 2024 21:36
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 4, 2024
@jeevb jeevb enabled auto-merge (squash) January 4, 2024 21:36
@dosubot dosubot bot added the enhancement New feature or request label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a726c36) 58.11% compared to head (77cde4c) 58.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4678   +/-   ##
=======================================
  Coverage   58.11%   58.12%           
=======================================
  Files         626      626           
  Lines       53815    53815           
=======================================
+ Hits        31275    31278    +3     
+ Misses      20039    20035    -4     
- Partials     2501     2502    +1     
Flag Coverage Δ
unittests 58.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevb jeevb merged commit b96419c into master Jan 4, 2024
47 checks passed
@jeevb jeevb deleted the jeev/buildkit-dns branch January 4, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants