-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artfs2/lineage #4681
Merged
Merged
Artfs2/lineage #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
documentation
Improvements or additions to documentation
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
labels
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## artifacts-shell-2 #4681 +/- ##
=====================================================
- Coverage 58.17% 58.16% -0.01%
=====================================================
Files 626 626
Lines 53764 53761 -3
=====================================================
- Hits 31278 31271 -7
- Misses 19984 19987 +3
- Partials 2502 2503 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Jan 5, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for tracking artifact usage upon execution start.
Tracking tag
Before create, the artifact service should write a string under the
_ua
key in the formwhere the version is the version of the artifact to be saved. At execution start, these tags are converted locally into artifact IDs containing only the artifactkey and the version (any partition information is not filled in). These IDs are then emitted alongside any artifact IDs that were the result of artifact queries, in the
CloudEventExecutionStart
event.The field in the idl has been renamed from
artifact_keys
toartifact_trackers
to be less confusing.Other changes
Remove an unecessary variable in registry.go file
Remove the initialization sql pattern in stdlib
Remove errant replace in stdlib go.mod