Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artfs2/lineage #4681

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Artfs2/lineage #4681

merged 6 commits into from
Jan 5, 2024

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jan 5, 2024

Changes for tracking artifact usage upon execution start.

Tracking tag

Before create, the artifact service should write a string under the _ua key in the form

project/domain/name@version

where the version is the version of the artifact to be saved. At execution start, these tags are converted locally into artifact IDs containing only the artifactkey and the version (any partition information is not filled in). These IDs are then emitted alongside any artifact IDs that were the result of artifact queries, in the CloudEventExecutionStart event.

The field in the idl has been renamed from artifact_keys to artifact_trackers to be less confusing.

Other changes

Remove an unecessary variable in registry.go file
Remove the initialization sql pattern in stdlib
Remove errant replace in stdlib go.mod

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 5, 2024
@wild-endeavor wild-endeavor changed the base branch from master to artifacts-shell-2 January 5, 2024 06:36
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (af39708) 58.17% compared to head (5015fcf) 58.16%.
Report is 3 commits behind head on artifacts-shell-2.

Files Patch % Lines
flyteadmin/pkg/manager/impl/execution_manager.go 24.00% 19 Missing ⚠️
flyteadmin/pkg/artifacts/registry.go 0.00% 1 Missing ⚠️
flytestdlib/database/db.go 0.00% 1 Missing ⚠️
flytestdlib/database/postgres.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           artifacts-shell-2    #4681      +/-   ##
=====================================================
- Coverage              58.17%   58.16%   -0.01%     
=====================================================
  Files                    626      626              
  Lines                  53764    53761       -3     
=====================================================
- Hits                   31278    31271       -7     
- Misses                 19984    19987       +3     
- Partials                2502     2503       +1     
Flag Coverage Δ
unittests 58.16% <21.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 5, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit b99af2b into artifacts-shell-2 Jan 5, 2024
42 of 44 checks passed
@wild-endeavor wild-endeavor deleted the artfs2/lineage branch January 5, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant