Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Agent Metadata Service Error Message #4682

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Improve Agent Metadata Service Error Message #4682

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7982102
improve agent error message
Jan 5, 2024
3bba4c1
Merge branch 'master' into agent-metadata-service-error-message-improve
Future-Outlier Jan 5, 2024
a48865e
Merge branch 'master' into agent-metadata-service-error-message-improve
Future-Outlier Jan 8, 2024
d60fc44
Merge branch 'master' into agent-metadata-service-error-message-improve
pingsutw Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flyteplugins/go/tasks/plugins/webapi/agent/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,10 @@
}

if !ok {
return nil, fmt.Errorf("failed to list agent with a non-gRPC error : [%v]", err)
return nil, fmt.Errorf("failed to list agent: [%v] with a non-gRPC error: [%v]", agentDeployment, err)

Check warning on line 369 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

View check run for this annotation

Codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L369 

Added line #L369 was not covered by tests
}

return nil, fmt.Errorf("failed to list agent with error: [%v]", err)
return nil, fmt.Errorf("failed to list agent: [%v] with error: [%v]", agentDeployment, err)

Check warning on line 372 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

View check run for this annotation

Codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L372 

Added line #L372 was not covered by tests
}

agents := res.GetAgents()
Expand Down
Loading