Add org to all flyteadmin endpoints for consistency #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
dosubot
bot
added
size:XXL
EngHabu
reviewed
Jan 19, 2024
| @@ -475,6 +509,10 @@ service AdminService { | |||
| option (google.api.http) = { | |||
| post: "/api/v1/events/workflows" | |||
| body: "*" | |||
| additional_bindings { | |||
| post: "/api/v1/events/workflows/org/{event.execution_id.org}" | |||
There was a problem hiding this comment.
Should it be after events?
Signed-off-by: Katrina Rogan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4746 +/- ##
=======================================
Coverage 58.18% 58.18%
=======================================
Files 626 626
Lines 53833 53833
=======================================
Hits 31322 31322
Misses 20003 20003
Partials 2508 2508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EngHabu
approved these changes
Jan 19, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Feb 5, 2024
* gen Signed-off-by: Katrina Rogan <[email protected]> * regen Signed-off-by: Katrina Rogan <[email protected]> * regen Signed-off-by: Katrina Rogan <[email protected]> --------- Signed-off-by: Katrina Rogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4663
What changes were proposed in this pull request?
Introduces consistency to all flyteadmin http bindings with the new optional org parameter.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link